Update AWS ALB plan-patches

[jochenehret]

• this set of patch files works with the recent bbl version 9.0.17
• note that there is still an ELB being created because you can't remove tf resources in _override files
• the Route 53 DNS record points to the new ALB

[nouseforaname]

hmm I think you should be able to use the _override to set the count for the replaced LB ( and all it's dependent resources) to 0 which should avoid creating it?

[jochenehret]

I've tried to use count = 0, but then you have to use an index wherever cf_router_lb is used. (cf_router_lb[0]). That would complicate the _override file approach.

A better solution would be to enhance the --lb-type command line parameter. It currently accepts "cf" or "concourse" as values. We could add a new value "cf-alb" and clearly separate the AWS ELB Terraform templates from the new ALB templates here: https://github.com/cloudfoundry/bosh-bootloader/blob/d1a959a02099809b07b70df58267d150fa1db05f/terraform/aws/template_generator.go#L42

[ramonskie]

i agree with the solution that we use --lb-type as this way its backwards compatible as well. and its the least complicated thing to implement without refactoring most of the terraform files.

i do think we should update the README and docs for this so its know that a --lb-type is now required

[ramonskie]

@jochenehret any update on this from your side?

[jochenehret]

No update currently from my side. I can't promise that I can fully implement this feature (with the --lb-type option)...