health-check-type is ignored from manifest.yml when pushing application

Open ivankoster opened this issue 5 years ago • 1 comments

When using the pushoperation health-check-type and related fields are ignored from a manifest file. This is caused by the v2 api of cf using the same field names, but the dashes are converted to underscores.

The fields with dashes are dropped in _generate_application_update_request in apps.py because AppManager.APPLICATION_FIELDS does not contain them, but the underscored versions.

Nov 12 '20 14:11 ivankoster

@ivankoster Hi. I am not sure I understand very well. You mean that

manifest could contain health-check-type or health-check-http-endpoint
if provided, set application attribute to health_check_type and or health-check-http-endpoint

Is that so? Would you like provide a pull request?

Dec 12 '20 16:12 antechrestos