Verify docker installation earlier when deploying container

[IRCody]

When containers are configured we want the container and the worker to be updated together (ideally). Failing earlier when we know docker is not installed keeps us from getting into a disjointed state between the worker and container.

• Tests
  • [ ] TODO (before merge)
  • [x] Tests included
  • [ ] Tests not necessary because:
• Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
  • [ ] I don't know
  • [ ] Required
  • [x] Not required because: not e2e test
• Public documentation
  • [ ] TODO (before merge)
  • [ ] Cloudflare docs PR(s):
  • [x] Documentation not necessary because: improved ux
• Wrangler V3 Backport
  • [ ] TODO (before merge)
  • [ ] Wrangler PR:
  • [x] Not necessary because: not a v3 feature.

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: efe7b83436799b0f113d61ac67339e174534e20b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
wrangler	Patch
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[pkg-pr-new[bot]]

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9667

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9667

miniflare

npm i https://pkg.pr.new/miniflare@9667

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9667

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9667

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9667

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9667

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9667

wrangler

npm i https://pkg.pr.new/wrangler@9667

commit: efe7b83

[github-actions[bot]]

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main cdr/container-docker-fail-fast might be a good starting point.

Notes:

• your PR branch should be named v3-backport-9667
• add the skip-v3-pr label to the current PR to stop this workflow from failing

[IRCody]

i think you can deploy without docker if you have an image registry link instead of a docker file? bit of an edge case to have containers and not docker, just flagging in case

That is a good point. I can add a check that you're supplying a Dockerfile and not a uri as well. Let me see how difficult that is.

[emily-shen]

i think you can deploy without docker if you have an image registry link instead of a docker file? bit of an edge case to have containers and not docker, just flagging in case

That is a good point. I can add a check that you're supplying a Dockerfile and not a uri as well. Let me see how difficult that is.

isDockerfile() === true should do it (helper function in containers-shared)