workers-sdk icon indicating copy to clipboard operation
workers-sdk copied to clipboard

Implement TODO: support symbolic links

Open jdarpinian opened this issue 1 year ago • 2 comments

Support symbolic links for static assets

Fixes #3094 (auto-closed but not resolved)

Supports symbolic links for static Pages assets in local dev server mode and in deploy.

Author has addressed the following

  • Tests
    • [X] TODO (before merge)
    • [ ] Included
    • [ ] Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • [X] I don't know
    • [ ] Required / Maybe required
    • [ ] Not required because:
  • Changeset (Changeset guidelines)
    • [X] TODO (before merge)
    • [ ] Included
    • [ ] Not necessary because:
  • Public documentation
    • [X] TODO (before merge)
    • [ ] Cloudflare docs PR(s):
    • [ ] Not necessary because:

jdarpinian avatar Aug 19 '24 23:08 jdarpinian

⚠️ No Changeset found

Latest commit: 10b6795caba1e91aecff337ea38290f879e95cfc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Aug 19 '24 23:08 changeset-bot[bot]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10462282837/npm-package-wrangler-6531

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6531/npm-package-wrangler-6531

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10462282837/npm-package-wrangler-6531 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10462282837/npm-package-create-cloudflare-6531 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10462282837/npm-package-cloudflare-kv-asset-handler-6531
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10462282837/npm-package-miniflare-6531
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10462282837/npm-package-cloudflare-pages-shared-6531
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10462282837/npm-package-cloudflare-vitest-pool-workers-6531
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10462282837/npm-package-cloudflare-workers-editor-shared-6531
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10462282837/npm-package-cloudflare-workers-shared-6531

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240806.1
workerd 1.20240806.0 1.20240806.0
workerd --version 1.20240806.0 2024-08-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

github-actions[bot] avatar Aug 20 '24 10:08 github-actions[bot]

@jdarpinian — can you say more about how you want to use symlinks? Is there something else you're using that depends on them?

irvinebroque avatar Nov 13 '24 02:11 irvinebroque

Thanks for submitting this PR @jdarpinian. Closing as we haven't heard from you for a while and this PR has conflicts, and would require work such as tests, changelogs etc. Feel free to reopen if you still want to work on it.

petebacondarwin avatar Feb 03 '25 14:02 petebacondarwin