workers-sdk icon indicating copy to clipboard operation
workers-sdk copied to clipboard

[do not merge] Don't strip version numbers from requirements.txt

Open garrettgu10 opened this issue 1 year ago • 3 comments

Currently we strip version numbers from requirements.txt when translating to a worker config (and that's probably what we want). However, for now we need to specify the version number to make some packages work within pyodide and workerd.

garrettgu10 avatar Feb 14 '24 18:02 garrettgu10

⚠️ No Changeset found

Latest commit: 0f370d65816a7a0641ba7b99421509291022d9fc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Feb 14 '24 18:02 changeset-bot[bot]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8024147674/npm-package-wrangler-5015

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5015/npm-package-wrangler-5015

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8024147674/npm-package-wrangler-5015 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8024147674/npm-package-create-cloudflare-5015 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8024147674/npm-package-cloudflare-kv-asset-handler-5015
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8024147674/npm-package-miniflare-5015
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8024147674/npm-package-cloudflare-pages-shared-5015
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8024147674/npm-package-cloudflare-vitest-pool-workers-5015

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240208.0
workerd 1.20240208.0 1.20240208.0
workerd --version 1.20240208.0 2024-02-08

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

github-actions[bot] avatar Feb 14 '24 18:02 github-actions[bot]

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 70.39%. Comparing base (cab7e1c) to head (0f370d6).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5015      +/-   ##
==========================================
+ Coverage   70.33%   70.39%   +0.05%     
==========================================
  Files         298      298              
  Lines       15515    15512       -3     
  Branches     3987     3985       -2     
==========================================
+ Hits        10913    10920       +7     
+ Misses       4602     4592      -10     
Files Coverage Δ
...r/src/deployment-bundle/find-additional-modules.ts 92.40% <0.00%> (+3.38%) :arrow_up:

... and 6 files with indirect coverage changes

codecov[bot] avatar Feb 14 '24 18:02 codecov[bot]

@garrettgu10 - what do you want to do with this PR? It needs a rebase and is currently set to "is draft".

petebacondarwin avatar May 15 '24 13:05 petebacondarwin