workers-rs icon indicating copy to clipboard operation
workers-rs copied to clipboard

chore: update matchit dependency

Open gytis-ivaskevicius opened this issue 2 years ago • 6 comments

Updated matchit dependency. This PR resolves https://github.com/cloudflare/workers-rs/issues/362

Tested and it is working, ready to be merged

gytis-ivaskevicius avatar Jul 30 '23 19:07 gytis-ivaskevicius

Also, I am not sure how the release cycle works here, when can I expect to see v0.0.18 released?

gytis-ivaskevicius avatar Jul 30 '23 20:07 gytis-ivaskevicius

Would love to see getting this merged. any updates on this? v0.4.6 was released on Feb 1, 2022...

9oelM avatar Oct 19 '23 05:10 9oelM

@gytis-ivaskevicius the tests are failing though

9oelM avatar Oct 19 '23 05:10 9oelM

any plan to merge this?

new version change the behavior of Catch-all Parameters

version doc
0.4.6 Catch-all parameters start with * and match everything including the trailing slash.
latest Catch-all parameters start with * and match everything after the /.

trim_start_matches("/"); in handler is too weird.

hxzhao527 avatar Dec 08 '23 02:12 hxzhao527

@hxzhao527 I just ended up forking it myself for my own use. It works great already. I recommend you do the same

9oelM avatar Dec 08 '23 03:12 9oelM

But matchit really needs to be updated, otherwise I see no hope in workers-rs. The dependency is too old already and it doesn't work as expected

9oelM avatar Dec 08 '23 05:12 9oelM

Done in #450

kflansburg avatar Feb 26 '24 17:02 kflansburg