cloudflared icon indicating copy to clipboard operation
cloudflared copied to clipboard

Update postrm.sh to fix incomplete uninstall

Open NanashiTheNameless opened this issue 2 years ago • 1 comments

this should supposedly fix https://github.com/cloudflare/cloudflared/issues/686 if i remember the issue correctly when i faced it, as "-f" will make it not hard fail if the file is not found.

NanashiTheNameless avatar Jan 23 '24 18:01 NanashiTheNameless

This change is in line with other postrm scripts in other projects which conventionally use rm -f and not rm on its own. Hopefully we can get someone to review and approve! This would fix quite a few instances of the same issue online (outside of GitHub) too :)

I appreciate your confirmation, I'm glad I remembered correctly, hopefully now one of the people with merge access will review and merge!

NanashiTheNameless avatar Feb 14 '24 06:02 NanashiTheNameless

@NanashiTheNameless wooo congrats!! finally got the merge and solved a years long issue. thanks @jcsf for approving <3

b4shful avatar Mar 05 '24 21:03 b4shful

@NanashiTheNameless wooo congrats!! finally got the merge and solved a years long issue. thanks @jcsf for approving <3

Ikr right? I'm so happy!

NanashiTheNameless avatar Mar 05 '24 22:03 NanashiTheNameless