cloudflare-rs icon indicating copy to clipboard operation
cloudflare-rs copied to clipboard

fix: removed field auto_added

Open r-birkner opened this issue 1 year ago • 5 comments

r-birkner avatar Feb 10 '25 08:02 r-birkner

Can you please provide more context on the issue this was causing?

kennetheversole avatar Mar 03 '25 02:03 kennetheversole

We use this crate to create DNS records for the ACME-challenge. With this field, there would be a panic because the crate failed to deserialize the response as the field was missing (it has been deprecated, see here).

I have noticed that you have overhauled the codebase quite a bit. We are running off of a fork with the applied fixes. I can try switching back to the upstream and see whether it works now.

r-birkner avatar Mar 03 '25 07:03 r-birkner

@kennetheversole Here is the error message produced when DNS records are listed with version 0.13.0:

API request to list existing records failed with: Invalid(reqwest::Error { kind: Decode, source: Error("missing field `auto_added`", line: 1, column: 181) })

Thanks @r-birkner for putting this fix together.

Riceman2000 avatar Mar 03 '25 15:03 Riceman2000

@r-birkner Could you rebase this please?

GoncaloGarcia avatar Mar 06 '25 11:03 GoncaloGarcia

?

ErcinDedeoglu avatar Mar 12 '25 04:03 ErcinDedeoglu