cloudflare-docs icon indicating copy to clipboard operation
cloudflare-docs copied to clipboard
verified publisher icon cloudflare

Update assign-pr owners

Open soheiokamoto opened this issue 3 years ago • 1 comments

This updates assign-pr owners, to have product owners to be reviewers. Individual GitHub usernames are added per internal wiki instructions.

Actions are rebuilt per instruction above:

cloudflare-docs $  cd .github/actions/assign-issue
cloudflare-docs/.github/actions/assign-issue $  npm install
cloudflare-docs/.github/actions/assign-issue $  npm run build

cloudflare-docs/.github/actions/assign-issue $  cd ../assign-pr
cloudflare-docs/.github/actions/assign-pr $  npm install
cloudflare-docs/.github/actions/assign-pr $  npm run build

Also, .github/CODEOWNERS.backup is updated to keep it in sync for Analytics and Logs section.

soheiokamoto avatar Aug 01 '22 23:08 soheiokamoto

@soheiokamoto I updated the PR description so that we don't disclose internal URLs in PR descriptions.

pedrosousa avatar Aug 02 '22 09:08 pedrosousa

Thanks @pedrosousa for updating PR description. I have updated the commit message as well. Removed bharatnc for now, as this user has not joined Cloudflare contributor group yet.

soheiokamoto avatar Aug 19 '22 11:08 soheiokamoto

Rebased and regenerated index.js files.

soheiokamoto avatar Aug 19 '22 11:08 soheiokamoto

Since @bharatnc is now a contributor and recognized here, added him for both projects. Regenerated index.js. Ready to merge and test.

soheiokamoto avatar Aug 22 '22 14:08 soheiokamoto

LGTM! Going ahead and merging this PR.

pedrosousa avatar Aug 23 '22 14:08 pedrosousa

It seems like now we are all pulled into all PRs: https://github.com/cloudflare/cloudflare-docs/pulls?q=is%3Apr+user-review-requested%3Asoheiokamoto

soheiokamoto avatar Aug 23 '22 17:08 soheiokamoto

This is the issue: https://github.com/cloudflare/cloudflare-docs/blob/b603dedb12e2cf71b7df858f190ac5c781902b61/.github/actions/assign-pr/index.ts#L75-L102

Everyone in owners.ts is treated as PCX authors, and whenever one of this PCX owner opens a PR, everyone (up to 10) is assigned.

soheiokamoto avatar Aug 23 '22 17:08 soheiokamoto

You're right. The assignment script currently assumes that all GitHub usernames in the OWNERS list are part of the PCX team, and so you're being tagged whenever the (real) PCX team is being tagged. If it's too distracting, we can revert this PR while we try to find a fix.

pedrosousa avatar Aug 23 '22 17:08 pedrosousa

What do you think of a fix like this? https://github.com/cloudflare/cloudflare-docs/pull/5612 If not, then we should revert this commit.

soheiokamoto avatar Aug 23 '22 18:08 soheiokamoto