cloudflare
EW-8589: Add documentation for allow_custom_ports workers compatibility flag
Summary
Add documentation for allow_custom_ports workers compatibility flag
@irvinebroque hopefully a little better now, for convenience I added a screenshot to the PR description and I'll keep it updated with the CR.
It looks like there's currently no flag to disable this, once it becomes default? We should always define a disable flag. (Admittedly it's hard to imagine why someone would want to disable this one but we should probably be consistent.)
It looks like there's currently no flag to disable this, once it becomes default? We should always define a disable flag. (Admittedly it's hard to imagine why someone would want to disable this one but we should probably be consistent.)
Well this is confusing, according to https://github.com/cloudflare/workerd/blob/main/src/workerd/io/compatibility-date.capnp#L60-L61 "Most features should not have a disable-flag defined unless we get requests from customers."
Also, I was of the impression we want to phase out the previous behaviour as it was confusing and have everyone eventually move over the to more logical behaviour where their custom ports are respected.
Well this is confusing, according to https://github.com/cloudflare/workerd/blob/main/src/workerd/io/compatibility-date.capnp#L60-L61 "Most features should not have a disable-flag defined unless we get requests from customers."
Oh... huh... I'm surprised by that comment... but I probably wrote it. :sweat_smile:
It looks like the comment is very old and in practice we have been assigning disable flags to everything.
https://github.com/cloudflare/workerd/pull/2521 added a disable flag, this PR is updated accordingly.
@cloudflare/pcx-technical-writing is there anything missing here to merge this?