cloudflare-docs
cloudflare-docs copied to clipboard
Adds information on "script will never generate a response" errors
Open questions:
- Is this is best place for this information. It feels too small for its own page, but also maybe too big for this specific spot. Any thoughts on where to best put it. As long as we can link to this code, I'm happy wherever.
- Should we add information about how libraries sometimes stick Promises in global state and we can't rely on that. I'm not sure exactly how to phrase it... "Some code may be relying on global cross-request state to resolve a Promise in another request. Workers Requests cannot rely on cross-request Promise resolution, so Request-blocking Promises should only get created within their own Request". Seems like a mouthful, and I'm not 100% positive on the specifics TBH.
Notes:
- I think ideally the WebSocket error has a different message. In that case, we could break that out into its own code, but we can do that whenever that message is changed.
refs https://github.com/cloudflare/workers-sdk/issues/5433
Deploying cloudflare-docs with
Cloudflare Pages
| Latest commit: |
c5a7f8e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f9b585dd.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://mikenomitch-swngar-errors-im.cloudflare-docs-7ou.pages.dev |
Files with changes (up to 15)
| Original Link | Updated Link |
|---|---|
| https://developers.cloudflare.com/workers/observability/errors/ | https://mikenomitch-swngar-errors-im.cloudflare-docs-7ou.pages.dev/workers/observability/errors/ |
Two thoughts here:
- Might make sense to reference w/in the table that this is a permutation of
1101at this line. - A helpful question to ask about the "new page vs section" debate is whether you can foresee folks grabbing this error message and copy/pasting into Google (which it seems like they would). If I'm making a correct assumption here, then you'd be better off with a new page b/c that has higher implicit authority than a section.
Ship it?
@kodster28 I didn't do either of your suggestions:
- I think it might be too much detail to mention this at the top level in that table
- I think we're okay with this on this one page. We'll be linking to this section via the error messages, so I think we should be good enough on discoverability. If we want to eventually break it off into its own thing, that seems okay to me, but I don't want to mess w the overall page arch too much.
If you're okay w that, any chance you can +1 so I can merge this? 🤞