Developer Spotlight - Custom access control for files in R2 using D1 and Workers

[justDMNK]

Hi everyone,

I just finished the tutorial called "Custom access control to images in R2 using D1 and Workers" which I proposed for the Developer Spotlight round. Just to address the possible confusion, I slightly adjusted the title to better reflect the content.

I tried to adhere and include the formatting guide as best as possible. Please let me know if there is anything to be improved, thanks.

[gitguardian[bot]]

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
-		Generic High Entropy Secret	a4693959a9bc870135b9415143f5a089c5e48c5d	content/workers/tutorials/custom-access-control-for-files-in-R2-using-D1-and-Workers	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secret safely. Learn here the best practices.
3. Revoke and rotate this secret.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

[megaconfidence]

Hey @justDMNK thanks for working on this article. While it's in the middle of a technical review, can you fix the following?

1. Move the content into an index.md file and place in a folder i.e custom-access-control-for-files-in-r2-using-d1-and-workers/ in the same directory?
2. Fix the formatting of the content. This is what it looks like today

Thanks!

[megaconfidence]

Completed tech review. LGTM!

[justDMNK]

Hi @dbenCF,

thank you for the nice words and your feedback, I appreciate it. I've applied most of your suggestions directly, but for one of the changes I've adjusted it slightly to clarify the wording. Please let me know if you have any additional feedback.

[db-cloudflare]

Looks great! One last small thing to change and then it's ready to publish.

[justDMNK]

I think GitGuardian is alerting a false positive, I made two suggestions that should help clear that.

I replaced the two demo secrets with placeholders and then added them as values to use within the text. But I think the GitGuardian is checking every commit and not just the newest one, as the check details still show that the secrets were detected within my first commit. Should I open a new pull request with a clean history?

[fariborz4]

Hiشاهد زحمتاتون بودم چیزیو خراب نمیکنم

در تاریخ جمعه ۱۴ ژوئن ۲۰۲۴،‏ ۲۱:۲۰ Dominik Fuerst @.***> نوشت:

I think GitGuardian is alerting a false positive, I made two suggestions that should help clear that.

I replaced the two demo secrets with placeholders and then added them as values to use within the text. But I think the GitGuardian is checking every commit and not just the newest one, as the check details still show that the secrets were detected within my first commit. Should I open a new pull request with a clean history?

— Reply to this email directly, view it on GitHub https://github.com/cloudflare/cloudflare-docs/pull/14618#issuecomment-2168496467, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANND2JD46RH5LLMA4BMWXATZHMUMRAVCNFSM6AAAAABH3CHQTGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRYGQ4TMNBWG4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

[db-cloudflare]

I think GitGuardian is alerting a false positive, I made two suggestions that should help clear that.

I replaced the two demo secrets with placeholders and then added them as values to use within the text. But I think the GitGuardian is checking every commit and not just the newest one, as the check details still show that the secrets were detected within my first commit. Should I open a new pull request with a clean history?

Opening a new PR might be the easiest thing to do unfortunately. Apologies for the inconvenience.

[justDMNK]

I think GitGuardian is alerting a false positive, I made two suggestions that should help clear that.

I replaced the two demo secrets with placeholders and then added them as values to use within the text. But I think the GitGuardian is checking every commit and not just the newest one, as the check details still show that the secrets were detected within my first commit. Should I open a new pull request with a clean history?

Opening a new PR might be the easiest thing to do unfortunately. Apologies for the inconvenience.

No worries, I just created another pull request (#15123), which did indeed pass the GitGuardian checks :)

[db-cloudflare]

Closed, duplicate can be found here https://github.com/cloudflare/cloudflare-docs/pull/15123