boringtun icon indicating copy to clipboard operation
boringtun copied to clipboard

Move to Mio/Tokio

Open Noah-Kennedy opened this issue 4 years ago • 11 comments

There is no reason we should be rolling our own epoll and kqueue. Let's just migrate to tokio or mio.

Noah-Kennedy avatar Feb 12 '22 22:02 Noah-Kennedy

I have some concerns about the amount of unsafe in here. Much of this is custom crap that can be ripped out and replaced easily.

Noah-Kennedy avatar Feb 15 '22 02:02 Noah-Kennedy

Should we expect these changes in near future?

zaid3tech avatar Mar 11 '22 10:03 zaid3tech

@zaid3tech yes, I don't have a set date to give you, but you should expect this soon.

Noah-Kennedy avatar Mar 11 '22 16:03 Noah-Kennedy

Thanks : )

zaid3tech avatar Mar 11 '22 21:03 zaid3tech

Is this still in the works? I'd love to see it implemented.

ngc0202 avatar Jun 13 '22 14:06 ngc0202

Yes, I just have had reduced bandwidth due to some other things.

Noah-Kennedy avatar Jun 14 '22 22:06 Noah-Kennedy

Hi all,

I hope all is well. Question, is the plan to just to replace the custom events system with mio, or to use Tokio runtime task scheduling etc?

ExternalReality avatar Nov 02 '22 16:11 ExternalReality

The plan is to use tokio.

Noah-Kennedy avatar Nov 02 '22 17:11 Noah-Kennedy

Hi @Noah-Kennedy, I know that this work has been on the backlog for sometime now. Any information on where this stands. I ask because any contribution my be dependent on something that might significantly change based on this rework. :-)

ExternalReality avatar Mar 22 '23 01:03 ExternalReality

Hi @Noah-Kennedy , I am trying to move to tokio. Can you create a tokio branch which I can submit PR to?

https://github.com/lz1998/wg-rs

lz1998 avatar Jun 21 '23 11:06 lz1998

I just wanted to check in on when the migration will be completed. FYI, I've reimplemented it using Tokio and hope that it could help with the migration: https://github.com/lodrem/wiretun

clnv avatar Jun 26 '23 04:06 clnv