Possible 3x improvement on addition?

Open karalabe opened this issue 5 years ago • 1 comments

Hey all, @Bren2010. We've received a downstream PR against go-ethereum that supposedly improves addition by a factor of 3. Would you be interested in maybe reviewing and upstreaming this PR here? https://github.com/ethereum/go-ethereum/pull/21515

Sep 04 '20 06:09 karalabe

This optimization only helps when you need to output the final result, which I wouldn't think is a major place you're spending time. Because while you're doing your curve math, you can leave the intermediate results non-affine.

Is it the case that you're spending a lot of time outputting points? Assigning to @armfazh for more in-depth review if so

Sep 04 '20 17:09 Bren2010