Optimize encoding

Open bencyoung-Fignum opened this issue 1 year ago • 5 comments

This change optimizes the binary mode formatter when UTF8 is chosen, and allows the memory stream implementation to be overridden (e.g. RecyclableMemoryStream)

Mar 20 '24 11:03 bencyoung-Fignum

Will try to look at this soon, but it may be next week.

Mar 20 '24 11:03 jskeet

It's no rush, we're just trying to optimize our eventing and this is something I wanted to check

Mar 20 '24 12:03 bencyoung-Fignum

There are a few things I'd probably want to change here - I wonder if the best thing is for me to create an PR from scratch rather than leave a bunch of nitpicks, then get you to review that new PR. Does that work for you?

Mar 21 '24 15:03 jskeet

Absolutely, it was just a PoC

Mar 21 '24 15:03 bencyoung-Fignum

Great. I'll try to come up with something next week.

Mar 21 '24 15:03 jskeet