[frontend] Advance the 'AND' rule in the definition of 'between' syntax for Hive and Presto
SQL parser: Move the '
What changes were proposed in this pull request?
Optimize the completion of syntax containing 'where x between 'a' and 'b''.
- (Please fill in changes proposed in this fix)
Move the order of '
'AND' {this.popState(); return 'BETWEEN_AND';}' in advance to before 'AND' in the hive and presto sql.jisonlex files, and regenerate the parser.
How was this patch tested?
-
(Please explain how this patch was tested. Ex: unit tests, manual tests) npm run test -- hiveAutocompleteParser.test.js
-
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)
Please review Hue Contributing Guide before opening a pull request.
@laochake Thanks for contributing! @JohanAhlen can you have a look?
gentle ping. @JohanAhlen
This PR is stale because it has been open 45 days with no activity and is not labeled "Prevent stale". Remove "stale" label or comment or this will be closed in 10 days.
Hi @laochake and sorry for our slow response here. I think this change makes sense. I see that you tested by running hiveAutocompleteParser.test.js but it doesn't contain all the test cases. I tried running hiveAutocompleteParser.Select.test.js with you change and it also passed. Could you perhaps update that test file with your specific issue (i.e. write a test that fails without your fix) and we will make sure to get this merged asap? Much appreciated and thanks for your patience.