Add HPA and PDB
What does this PR do?
Adding HorizontalPodAutoscaler and Disruption Budget for the Application
Where should the reviewer start?
https://github.com/cloudability/metrics-agent/tree/master/charts/metrics-agent added : - pdb.yaml - hpa.yaml update: - values.yaml with pdb and hap. By default both are disabled with false value so no change and can be enabled with true value
How should this be manually tested?
Command to see the resources
helm template cloudability . -f values.yaml --dry-run | more
Any background context you want to provide?
We are creating our own helm chart but would like to use the public one so adding all our new features to public helm charts for everyones benefits.
What picture best describes this PR (optional but encouraged)?
Adding HorizontalPodAutoscaler and Disruption Budget for the Application
What are the relevant Github Issues?
No issue
Developer Done List
- [ YES] Tests Added/Updated
- [ NO] Updated README.md
- [x] Verified backward compatible
- [x] Verified database migrations will not be catastrophic
- [ YES] Considered Security, Availability and Confidentiality
For the Reviewer:
Just HPA and PDB's are added so no functionality change. Everything else will be same.
By approving this PR, the reviewer acknowledges that they have checked all items in this done list.
Reviewer/Approval Done List
- [ ] Tests Pass Locally
- [ ] CI Build Passes
- [ ] Verified README.md is updated
- [ ] Verified changes are backward compatible
- [ ] Reviewed impact to Security, Availability and Confidentiality (if issue found, add comments and request changes)
Kudos, SonarCloud Quality Gate passed! 
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
@apptiopzuo @daniel-spray Could you please check and approve. Just adding HPA and PDB for helm charts.
@tiwarisanjay: Metrics agent doesn't support running more than one pod at this time.
@apptiopzuo So how it supports high availability? One pod can easily go down if one zone is bad.
@apptiopzuo So how it supports high availability? One pod can easily go down if one zone is bad.
You are right. We will need evaluate how to support the HA from the design.
@apptiopzuo You can add redis in front. Check ArgoCD HA