metrics-agent icon indicating copy to clipboard operation
metrics-agent copied to clipboard

Add HPA and PDB

Open tiwarisanjay opened this issue 3 years ago • 7 comments

What does this PR do?

Adding HorizontalPodAutoscaler and Disruption Budget for the Application

Where should the reviewer start?

https://github.com/cloudability/metrics-agent/tree/master/charts/metrics-agent added : - pdb.yaml - hpa.yaml update: - values.yaml with pdb and hap. By default both are disabled with false value so no change and can be enabled with true value

How should this be manually tested?

Command to see the resources

 helm template cloudability  . -f values.yaml --dry-run | more

Any background context you want to provide?

We are creating our own helm chart but would like to use the public one so adding all our new features to public helm charts for everyones benefits.

What picture best describes this PR (optional but encouraged)?

Adding HorizontalPodAutoscaler and Disruption Budget for the Application

What are the relevant Github Issues?

No issue

Developer Done List

  • [ YES] Tests Added/Updated
  • [ NO] Updated README.md
  • [x] Verified backward compatible
  • [x] Verified database migrations will not be catastrophic
  • [ YES] Considered Security, Availability and Confidentiality

For the Reviewer:

Just HPA and PDB's are added so no functionality change. Everything else will be same.

By approving this PR, the reviewer acknowledges that they have checked all items in this done list.

Reviewer/Approval Done List

  • [ ] Tests Pass Locally
  • [ ] CI Build Passes
  • [ ] Verified README.md is updated
  • [ ] Verified changes are backward compatible
  • [ ] Reviewed impact to Security, Availability and Confidentiality (if issue found, add comments and request changes)

tiwarisanjay avatar Nov 04 '22 15:11 tiwarisanjay

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 04 '22 15:11 CLAassistant

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Nov 04 '22 15:11 sonarqubecloud[bot]

@apptiopzuo @daniel-spray Could you please check and approve. Just adding HPA and PDB for helm charts.

tiwarisanjay avatar Nov 04 '22 15:11 tiwarisanjay

@tiwarisanjay: Metrics agent doesn't support running more than one pod at this time.

apptiopzuo avatar Nov 10 '22 17:11 apptiopzuo

@apptiopzuo So how it supports high availability? One pod can easily go down if one zone is bad.

tiwarisanjay avatar Nov 10 '22 18:11 tiwarisanjay

@apptiopzuo So how it supports high availability? One pod can easily go down if one zone is bad.

You are right. We will need evaluate how to support the HA from the design.

apptiopzuo avatar Nov 17 '22 17:11 apptiopzuo

@apptiopzuo You can add redis in front. Check ArgoCD HA

tiwarisanjay avatar Nov 18 '22 17:11 tiwarisanjay