metrics-agent icon indicating copy to clipboard operation
metrics-agent copied to clipboard

Fixes #145. Fix specification of drop in helm chart

Open mikhailadvani opened this issue 4 years ago • 5 comments

What does this PR do?

Correctly allows the specification of drop in the helm chart values.

Where should the reviewer start?

Helm chart.

How should this be manually tested?

Use the helm template command to validate locally. You can add remove items from the drop array to check different combinations

Any background context you want to provide?

What picture best describes this PR (optional but encouraged)?

What are the relevant Github Issues?

#145

Developer Done List

  • [x] Tests Added/Updated
  • [x] Updated README.md
  • [x] Verified backward compatible
  • [x] Verified database migrations will not be catastrophic
  • [x] Considered Security, Availability and Confidentiality

For the Reviewer:

By approving this PR, the reviewer acknowledges that they have checked all items in this done list.

Reviewer/Approval Done List

  • [ ] Tests Pass Locally
  • [ ] CI Build Passes
  • [ ] Verified README.md is updated
  • [ ] Verified changes are backward compatible
  • [ ] Reviewed impact to Security, Availability and Confidentiality (if issue found, add comments and request changes)

mikhailadvani avatar Nov 08 '21 12:11 mikhailadvani

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 08 '21 12:11 CLAassistant

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Nov 08 '21 12:11 sonarqubecloud[bot]

Hi @mikhailadvani thank you for your contribution. We've reviewed these changes and everything looks good. We will release these changes soon.

AnthonyApptio avatar Dec 16 '21 22:12 AnthonyApptio

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Dec 16 '21 22:12 sonarqubecloud[bot]

Hi @mikhailadvani After further review, we realized this PR was made from your fork of the metrics agent. We're happy to merge your fix but to do so we would need you to create a feature branch with your changes and submit a PR. Then we can merge it to master.

AnthonyApptio avatar Dec 17 '21 18:12 AnthonyApptio