cljs-tooling icon indicating copy to clipboard operation
cljs-tooling copied to clipboard

code complete don't support plain js object

Open shaqtsui opened this issue 8 years ago • 4 comments

When type: (js/THR

Expected complete list: (js/THREE ...

I think a enhancement required here

shaqtsui avatar Nov 07 '17 07:11 shaqtsui

This is something that has been done in lumo and can be easily ported over: https://github.com/anmonteiro/lumo/blob/master/src/cljs/snapshot/lumo/repl.cljs#L1297-L1320

arichiardi avatar Mar 03 '18 21:03 arichiardi

Not easily :smile: it looks like the implementation is Clojure for vanilla JVM so the above code would only work for self-hosted REPLs

arichiardi avatar Aug 09 '18 15:08 arichiardi

For the JVM side we can implement this once CLJS-1047 is done. Feel free to vote on that ticket if you're registered on JIRA.

I'm not sure what makes most sense for the self-host case but what Lumo does with completion-candidates-for-node-modules and completion-candidates-for-closure-js looks sane. Maybe we should port that over.

cichli avatar Jan 19 '19 17:01 cichli

FYI this has been implemented here https://github.com/rksm/clj-suitable but uses dynamic runtime inspection and not static code analysis.

rksm avatar Aug 09 '19 14:08 rksm