goog.require emitted for every complete request

Open thheller opened this issue 6 years ago • 3 comments

Sorry for posting an image, didn't know how to show it otherwise. Note that I pressed auto-complete a couple of times and each time a goog.require is done. Using the rebel-readline setup.

Seems like something that should only be done once?

clj-suitable

(not to mention all the other goog.addDependency stuff but I think that is the REPL doing that because of the require)

Oct 07 '19 23:10 thheller

Yes, this should be done only once. For repls other than shadow-cljs this is the case, I'll add a load check for shadow in the next version.

Oct 11 '19 12:10 rksm

That example was from rebel-readline + figwheel. Didn't involve shadow-cljs at all.

Oct 11 '19 14:10 thheller

OK, thanks, checked again and the loading only exist for nrepl. Will be fixed.

Oct 11 '19 15:10 rksm