pattern icon indicating copy to clipboard operation
pattern copied to clipboard

Make mysqlclient an optional dependency

Open willprice opened this issue 7 years ago • 9 comments

MySQL shouldn't be a core dependency, I've moved it to an extra package which can be installed as pip install pattern[mysql] if users wish to install with mysql support.

willprice avatar Nov 17 '18 22:11 willprice

Coverage Status

Coverage decreased (-0.8%) to 67.472% when pulling 3b77852c51d1e80b17d9abba0be5efad6a2fd7a5 on uob-vil:master into 5b85d998c30ddc6772b56310713530224466083a on clips:master.

coveralls avatar Nov 17 '18 22:11 coveralls

+1

gutomaia avatar Feb 18 '19 18:02 gutomaia

+1

zh0uquan avatar Feb 25 '19 10:02 zh0uquan

thank you. i tried to get pattern running on mac with this:

brew install mysql-client
pip3 install pattern

But I couldn't get it to work. This works though:

pip3 install git+https://github.com/uob-vil/pattern.git

kylemcdonald avatar Apr 17 '19 03:04 kylemcdonald

It would be awesome to see this happen! :-)

tuky avatar Nov 07 '19 15:11 tuky

Mysql really complicates the installation, as it turns out installing the myssqlclient on a windows machine is non trivial. Any luck on removing this dependency? I've linked some related issues which can all be closed when this is resolved.

Sjoerd82 avatar Jan 21 '21 14:01 Sjoerd82

I get:

File "/usr/lib/python3.10/zipfile.py", line 1267, in init self._RealGetContents() File "/usr/lib/python3.10/zipfile.py", line 1334, in _RealGetContents raise BadZipFile("File is not a zip file") zipfile.BadZipFile: File is not a zip file

ndvbd avatar Dec 05 '22 09:12 ndvbd

@tom-de-smedt Can you please merge this or mark the GitHub project as Archived?

sanmai-NL avatar Feb 10 '23 11:02 sanmai-NL