Clint Valentine

Results 66 comments of Clint Valentine

@nh13 ready for a re-review when you have time! Thanks!

Ready for another re-review with fresh eyes! 👀 I had a few requests for a more detailed algorithmic overview than what is currently provided. My goal is to have the...

@nh13 I'd still like the `__getitem__` aspect of #155 reverted. I do think that code is a footgun and shouldn't have been merged. I'd be happy to open the PR...

I'm +1 and +1 on these ideas. Restructuring tests outside of the package tree is also slightly preferred in the `pytest` docs and keeps tests out of package distribution (making...

@nh13 tox works well for this and will run multiple GHA jobs as expected: - https://github.com/tox-dev/tox-gh Here's an example from a personal OSS project: And the associated `pyproject.toml` config: ```toml...

What I do locally is use [pyenv](https://github.com/pyenv/pyenv), a very simple Python version management tool, to install all versions of Python on my local. I think of this as the environment...

@nh13 passing by comment here. Would there be a way to let the missing qualities truly be missing qualities and make the consensus probability math tolerant of the missing term?...

I didn't see #42 until also attempting a solution: - https://github.com/fulcrumgenomics/fgsv/compare/main...cv_duplicate_mark

Or have `dec_hook` run prior to the builtin conversion, but yes I want this too!

I also have the same issue on `2.2` and notice there are still references to the mispelling: ```console ❯ git grep parial rendercv/__init__.py:_parial_install_error_message = ( rendercv/cli/__init__.py: from .. import _parial_install_error_message...