hackernews-react-graphql icon indicating copy to clipboard operation
hackernews-react-graphql copied to clipboard

Permalinks don't work.

Open danem opened this issue 8 years ago • 3 comments

See:

https://news.ycombinator.com/item?id=15380658

vs

http://www.hnclone.win/item?id=15380658

danem avatar Oct 02 '17 00:10 danem

Hm that's strange. I didn't think this would happen but it's probably a small change. A pull request is welcome otherwise I'll take a look later.

Edit: I had a look and it's just that the page to view a comment instead of a news item hasn't been completed

Edit 2: It's because comments and news items are fetched on the same url. The app throws an error if a news item doesn't have a Title (because comments don't have those)

clintonwoo avatar Oct 02 '17 02:10 clintonwoo

@clintonwoo I will take over this issue if that's ok with you.

jsainthilaire avatar Feb 16 '18 00:02 jsainthilaire

@jsainthilaire sure thing mate

clintonwoo avatar Feb 16 '18 00:02 clintonwoo