clinicjs
[PARKED] Highlight all the occurrences for the selected frame
This PR won't be merged but we'll keep it as a proof of concept
This PR allows the user to quickly see how many other occurrences of the selected function are displayed in the graph. When hovering over a frame, the new component (sitting just next to the selection-controls) shows the number of other occurrences of the hovered frame, as well as the total % of the time spent by the function. Clicking on the button triggers an overlay (tooltip) containing the list of all the other occurrences (not including the selected frame) and the % of time spent running them.
On hover, the corresponding frame on the graph gets highlighted. On click, the corresponding frame on the graph gets selected
Maybe we can do the highlighting in renderFrame() on the canvas instead? this method could set a property on the frame objects and renderFrame() can check it. then it would automagically work with animations and stuff (and it should be very performant even if there are hundreds/thousands of occurrences)
Absolutely
latest demo: https://upload.clinicjs.org/public/0bc43b6532617aaafe2bf2906c7b28c5c5ba3353a5f3cdb5c85f03f18b9231db/5759.clinic-flame.html#selectedNode=3057&zoomedNode=&exclude=3c0&showOccurrences=true
Great work, very interesting. It's great to be able to explore how common multiple occurrences are.
As discussed last week the UX needs some refining so it's a bit less surprising - will experiment with this and make some suggestions. Really awesome to be able to explore the possibilities like this.
My first thought is to maybe only show the same occurrences on the flamegraph strongly on selecting a frame, so there's a bit less noise while hovering around, and to use a subtle background and/or a little marker triangle in the corner rather than strong outlines, but it needs some experimentation.
This dropdown is super cool. My first thoughts from playing with this are similar; the outline can be hard to see so a light background similar to what the search does may be better (and there's precedent for it, so)
I feel like one option for the button/dropdown combo is to split it up, the dropdown can still be useful even if other occurences aren't being highlighted right now.
I'd perhaps also like to see the dropdown labelled with something like '16 occurences' instead of just '16' to clarify what it's for without having to hover, if that doesn't take too much space
