joint icon indicating copy to clipboard operation
joint copied to clipboard

Adjust center position of new scale wrt previous scale, not 1.

Open avshenuk opened this issue 5 years ago • 4 comments

Tested locally and this now works correctly. A simple example: if you're already on scale 2, and trying to set the scale to 2 again, simply glancing through the previous code, you can see that it will move the origin when it shouldn't at all.

avshenuk avatar Oct 04 '20 20:10 avshenuk

Hi @avshenuk, thank you! This looks good. I just need to test whether it is a breaking change or not.

kumilingus avatar Oct 16 '20 14:10 kumilingus

This PR is stale because it has been open 60 days with no activity. Please remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar May 06 '22 09:05 github-actions[bot]

This PR is stale because it has been open 60 days with no activity. Please remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Jul 06 '22 00:07 github-actions[bot]

This PR is stale because it has been open 60 days with no activity. Please remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Sep 05 '22 00:09 github-actions[bot]

This PR is stale because it has been open 60 days with no activity. Please remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Nov 05 '22 00:11 github-actions[bot]

This PR is stale because it has been open 60 days with no activity. Please remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Jan 05 '23 00:01 github-actions[bot]

This PR is stale because it has been open 60 days with no activity. Please remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Mar 07 '23 00:03 github-actions[bot]

This PR is stale because it has been open 60 days with no activity. Please remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar May 07 '23 00:05 github-actions[bot]

This PR is stale because it has been open 60 days with no activity. Please remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Jul 07 '23 00:07 github-actions[bot]

This PR is stale because it has been open 60 days with no activity. Please remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Sep 06 '23 00:09 github-actions[bot]

This PR is stale because it has been open 60 days with no activity. Please remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Nov 20 '23 00:11 github-actions[bot]

This PR is stale because it has been open 60 days with no activity. Please remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Jan 20 '24 00:01 github-actions[bot]

Sorry for the delay. It is a breaking fix and it was addressed here: https://github.com/clientIO/joint/pull/2495 Thanks for pointing that out.

kumilingus avatar Jan 22 '24 11:01 kumilingus