proxy icon indicating copy to clipboard operation
proxy copied to clipboard

Remove unused features (socket activation and KSM)

Open jodh-intel opened this issue 8 years ago • 10 comments

jodh-intel avatar Nov 30 '17 17:11 jodh-intel

Note that this cannot realistically land until we a stand-alone daemon to handle KSM, hence the dnm label.

See:

  • #168
  • https://github.com/clearcontainers/runtime/issues/795

jodh-intel avatar Nov 30 '17 17:11 jodh-intel

kubernetes qa-failed 👎

clearcontainersbot avatar Nov 30 '17 18:11 clearcontainersbot

The tests are failing due to https://github.com/clearcontainers/tests/blob/master/.ci/install_proxy.sh#L34..L35 which is trying to modify the proxy's service file (which has been removed by this PR).

Once we have a KSM daemon, we can then:

  • Raise a tests PR to tweak install_proxy.sh.
  • Re-run the CI tests for this PR.

jodh-intel avatar Dec 01 '17 10:12 jodh-intel

kubernetes qa-failed 👎

clearcontainersbot avatar Dec 14 '17 02:12 clearcontainersbot

kubernetes qa-failed 👎

clearcontainersbot avatar Dec 14 '17 14:12 clearcontainersbot

kubernetes qa-failed 👎

clearcontainersbot avatar Jan 09 '18 01:01 clearcontainersbot

Blocked on https://github.com/clearcontainers/tests/issues/913.

We cannot remove the KSM functionality from the proxy until the issue above is resolved since the tests currently install the proxy "manually" using:

  • https://github.com/clearcontainers/tests/blob/master/.ci/install_proxy.sh

(Note that user systems would not be affected by removing the functionality since they have the cc-ksm-throttler package installed already).

jodh-intel avatar Feb 19 '18 17:02 jodh-intel

Hi @chavafg, @grahamwhaley - now that https://github.com/clearcontainers/tests/pull/920 has landed, could you both confirm that I can continue with removing these features from the proxy?

jodh-intel avatar Feb 22 '18 10:02 jodh-intel

Let me check some stuff. afaict when we landed https://github.com/clearcontainers/tests/pull/911 then the metrics CI got to do the right thing, but it then appears when we landed https://github.com/clearcontainers/tests/pull/920 it might be back to being nobbled again (that is, KSM seems to be in effect even when we try to turn it off). I'll have to go debug - which is made a fraction harder as the scripts don't generate any ack/nack/logs about what they are doing, so I have to go poke around the actual system... pls wait!

(oh, and apparently you need a rebase I think any how ;-) )

grahamwhaley avatar Feb 22 '18 11:02 grahamwhaley

yep - I'll hold off rebasing until I get two confirmations :)

jodh-intel avatar Feb 22 '18 14:02 jodh-intel