Cameron Kaiser

Results 190 comments of Cameron Kaiser

I'm still not wild about the `std::log2` changes, because the code as written compiles fine on 10.4 and it's a change I have to carry forward for future OTS updates....

> If not that, I wonder if we might get away with one single #define in one common header. Perhaps something like this might work? > > ``` > --TEST-FOR-10.5-&&-GCC-LESS-THAN-7...

In `Parser.cpp`, look at lines 4585 and 4791. Then, in `BytecodeEmitter.cpp`, fix the assertions in lines 5499 and remove the assertion at 5521. This should be enough to get `const`...

This isn't worth it, might regress other code, and doesn't fix enough to get Github working properly. Wontfixing for TenFourFox.

If we can get async functions working, we might reexamine this hack.

This may also fix Discord, see https://tenfourfox.tenderapp.com/discussions/problems/8804-discord-problem

This enables login to Discord, but now it just "crashes" (the page complains Discord has crashed). Changing the user agent makes no difference.

There are various failures, but they aren't unexpected: /Volumes/BruceDeuce/src/tenfourfox/js/src/jit-test/tests/parser/letContextualKeyword.js:7:5 Error: Assertion failed: got false, expected true Stack: expectError@/Volumes/BruceDeuce/src/tenfourfox/js/src/jit-test/tests/parser/letContextualKeyword.js:7:5 @/Volumes/BruceDeuce/src/tenfourfox/js/src/jit-test/tests/parser/letContextualKeyword.js:21:1 ## ecma_6/LexicalEnvironment/const-declaration-in-for-loop.js: rc = 3, run time = 0.723338 1146644: Don't...

No offense, but I don't make one-offs since we don't have continuous integration and builds are lengthy (and they're too large to attach here anyway). The patch above is essentially...

Since the latest attempt at #521 ended in failure again, and this might add some partial functionality on some sites, we'll try it (with test fixes) for FPR15.