curdling icon indicating copy to clipboard operation
curdling copied to clipboard

VersionConflict (on versions containing letters, maybe?)

Open starenka opened this issue 12 years ago • 2 comments

    [KRetrieving: [##########] 100% (107 requested, 9 retrieved, 104 built, 3 failed)2013-11-06 15:06:39,400:curdling.install:ERROR:best_version('django'): /var/lib/jenkins/workspace/scorp_default_curdlingtest/.env/local/lib/python2.7/site-packages/curdling/install.py:200 (load_installer) _, chosen_requirement = self.mapping.best_version(package_name)
    Traceback (most recent call last):
      File "/var/lib/jenkins/workspace/scorp_default_curdlingtest/.env/local/lib/python2.7/site-packages/curdling/install.py", line 200, in load_installer
        _, chosen_requirement = self.mapping.best_version(package_name)
      File "/var/lib/jenkins/workspace/scorp_default_curdlingtest/.env/local/lib/python2.7/site-packages/curdling/mapping.py", line 143, in best_version
        ', '.join(sorted(self.available_versions(package_name), reverse=True)),
    VersionConflict: Requirement: django (>= 1.4), Available versions: 1.6c1

starenka avatar Nov 06 '13 14:11 starenka

curdling should behave like pip in this case. It should ignore pre releases unless --pre is specified.

thedrow avatar Nov 06 '13 16:11 thedrow

Good catch! This bug is definitely somewhere in the Mapping.best_version() function. This ticket is a good candidate for a patch if any of you guys want to take a stab on it. I can help you getting started with the development and even write the tests beforehand.

@thedrow, the --pre option is definitely the way to go! It also reminds me that we should also take care of the issue #46 as soon as we fix this one.

clarete avatar Nov 06 '13 16:11 clarete