ckChangeLog icon indicating copy to clipboard operation
ckChangeLog copied to clipboard
verified publisher icon cketti

Version 2.0.0

Open cketti opened this issue 9 years ago • 5 comments

Feel free to provide feedback.

Fixes #34 Fixes #42 Fixes #48

cketti avatar Jan 13 '17 10:01 cketti

@cketti Any timeline for the release of v2?

johnjohndoe avatar Feb 05 '18 19:02 johnjohndoe

I'm hoping to release 2.0.0 in the next couple of days. Last chance to provide feedback.

cketti avatar May 13 '18 13:05 cketti

Great! I am trying to look into the changes within this week and will provide feedback.

johnjohndoe avatar May 13 '18 19:05 johnjohndoe

First review

  1. I recommend using lowercase for both artifacts: ckchangelog-legacy-dialog instead of ckChangeLog-legacy-dialog and ckchangelog-core instead of ckChangeLog-core. A typo due to wrong capitalization is actually pretty hard to spot. I believe lowercase dependency names are common practice. Further, the README is not reflecting the current (camelcase) name.
  2. Please consider recommending implementation "de.cketti.library.changelog:ckchangelog-legacy-dialog:2.0.0" instead of compile 'de.cketti.library.changelog:ckchangelog-legacy-dialog:2.0.0' in the README. Changes are: implementation over compile and double quotes over single quotes.
  3. In my project I have to add both artifacts ckChangeLog-legacy-dialog and ckChangeLog-core in order to show a dialog. It seems that the former artifact does not introduce a transitive dependency. If this is on purpose it should be clearly stated in the README. If ckChangeLog-core is missing a ClassNotFoundException: Didn't find class "de.cketti.changelog.ChangeLog" is thrown.
  4. Is there a technical reason to raise the minSdkVersion from 4 to 14? I saw the support-annotations library - I believe it hasn't changed too much over the last versions. As far as I saw you are only using IdRes, RawRes and Nullable.
  5. The com.android.support:support-v4:27.1.1 dependency in the sample-legacy-dialog module introduces a long list of transitive dependencies which are obsolete. You can replace it with com.android.support:support-fragment:27.1.1.
  6. You could provide a migration guide as a wiki page in addition to the README.

johnjohndoe avatar May 17 '18 20:05 johnjohndoe

Hi! This should be merged. I am trying to compile with build tools version 28.0.3 but it's failing.

touficbatache avatar Nov 14 '18 18:11 touficbatache