Converted ckeditor5-dev-* packages to ESM

Open pomek opened this issue 1 year ago • 1 comments

Suggested merge commit message (convention)

Other: The CKEditor 5 Dev packages are now ESM.

Other: The @ckeditor/jsdoc-plugins package is no longer available as CKEditor 5 documentation uses TypeScript sources to prepare API docs. The package is no longer use by us anywhere. Hence, we decided to remove a dead code.

MAJOR BREAKING CHANGE (utils): The builds.getDllPluginWebpackConfig() function is now asynchronous now.

MAJOR BREAKING CHANGE (utils): The following functions from the bundler object are no longer available: createEntryFile(), getEditorConfig(), getPlugins().

MAJOR BREAKING CHANGE (utils): The following functions from the stream object are no longer available: isTestFile(), isSourceFile(), isJSFile().

MAJOR BREAKING CHANGE (utils): The styles.themeLogger() function is no longer exposed publicly.

MAJOR BREAKING CHANGE (tests): The IntelliJ Karma configuration path needs to be updated. Now, it ends with the cjs suffix instead of js.

MAJOR BREAKING CHANGE (docs): The package uses only TypeDoc to build the documentation. The build() function no longer supports type property in the configuration.

MAJOR BREAKING CHANGE (docs): An array of ignored files must be specified as ignoreFiles instead of negating a glob pattern in sourceFiles.

MAJOR BREAKING CHANGE: The following packages have been converted to ESM. To load them, use an import statement instead of require().

Additional information

Resolve the following TODOs before merging:

[x] https://github.com/ckeditor/ckeditor5-dev/pull/1011/files/890186e9189c5b9610441a509e73ce8daff2ff9f#diff-e2954b558f2aa82baff0e30964490d12942e0e251c1aa56c3294de6ec67b7cf5
[x] https://github.com/ckeditor/ckeditor5-dev/pull/1011/files/890186e9189c5b9610441a509e73ce8daff2ff9f#diff-e2954b558f2aa82baff0e30964490d12942e0e251c1aa56c3294de6ec67b7cf5
[x] https://github.com/ckeditor/ckeditor5-dev/pull/1011/files/890186e9189c5b9610441a509e73ce8daff2ff9f#diff-e2954b558f2aa82baff0e30964490d12942e0e251c1aa56c3294de6ec67b7cf5
[x] https://github.com/ckeditor/ckeditor5-dev/pull/1011#pullrequestreview-2314408021
[ ] https://github.com/ckeditor/ckeditor5-dev/pull/1011#discussion_r1768356461
[ ] https://github.com/ckeditor/ckeditor5-dev/pull/1011#discussion_r1771187171

Sep 19 '24 04:09 pomek

I think the job is done. I do not want to revert the alpha release changes if we want to re-release it.

When it comes to merging the PR, I would like to handle it once CKEditor 5 releases its next minor.

Sep 24 '24 10:09 pomek