ckeditor4-angular icon indicating copy to clipboard operation
ckeditor4-angular copied to clipboard

Unstable 'paste' and 'afterPaste' tests on FF

Open Dumluregn opened this issue 5 years ago • 9 comments

Are you reporting a feature request or a bug?

Unstable tests

Provide detailed reproduction steps (if any)

  1. Run tests with npm run test
  2. See the result in FF
  3. If everything passed, try again

Expected result

Tests pass each time.

Actual result

Tests for paste and afterPaste events are unstable and fail sometimes.

Other details

I'm not sure but it can be caused by changes introduced in #115.

  • Browser: FF 78
  • OS: macOS
  • Integration version: 1.2.2
  • CKEditor version: 4.14.1
  • Installed CKEditor plugins: default

Dumluregn avatar Jul 16 '20 10:07 Dumluregn

That's sad as we just fixed it for IE11 :sob: Anyway, maybe fixes introduced in #115 should be done for IE11 only and for the rest of the browsers it should be done as before the fix :thinking:

f1ames avatar Jul 16 '20 11:07 f1ames

I cannot reproduce it on Linux Fedora 32. They also don't seem to fail on CI. @Dumluregn is this issue macOS specific?

jacekbogdanski avatar Jul 28 '20 11:07 jacekbogdanski

Not sure. It occurs pretty consistently for me, so if you can't reproduce it you may be right that it happens on macOS only. @f1ames @hub33k could you check if tests fail on your machines?

Dumluregn avatar Jul 28 '20 15:07 Dumluregn

It fails on my machine (Manjaro Linux). For the first time it passes but when I run tests for the second time, it fails.

hub33k avatar Jul 30 '20 10:07 hub33k

It seems the tests pass on FF if the browser is focused and fail otherwise. Could you guys check if that's true for you? @jacekbogdanski @hub33k

Dumluregn avatar Jul 30 '20 12:07 Dumluregn

Yes, these tests fails for me when FF is not focused.

hub33k avatar Jul 30 '20 12:07 hub33k

Let's leave it for now since it passes on CI.

f1ames avatar Jul 31 '20 14:07 f1ames

I see that these tests are failing for me know just regularly: image

(4 of them based on afterPaste event)

Edit: I didn't notice https://github.com/ckeditor/ckeditor4-angular/issues/119#issuecomment-666331780 and indeed that's the troubling part.

jacekbogdanski avatar Dec 14 '20 14:12 jacekbogdanski

Seems like these tests always fail now :disappointed:

Comandeer avatar Jun 05 '23 14:06 Comandeer