cli icon indicating copy to clipboard operation
cli copied to clipboard

feat: Introduce --no-default-rules flag, deprecate --create-rules

Open Praveen005 opened this issue 1 year ago • 1 comments

This PR addresses the issue in #446

In here, I,

  • Added a new --no-default-rules flag to control default firewall rule creation.
  • Marked --create-rules as deprecated but kept for backward compatibility.
  • Added a deprecation warning for --create-rules usage.
  • Error out when both the flags are used simultaneously.
  • Updated the documentation to reflect the changes.

Why deprecate --create-rules flag ?

If we see the documentation, it seems --create-rules was introduced to give users a way to create firewalls without any default firewall rules set.

image

But, now that we have --no-default-rules flag, deprecating (not removing) --create-rules I feel is the obvious next step here.

Note: when a flag is deprecated, It continues to function but does not show up in help or usage messages.


Result:

  1. Firewall correctly created with default rules without --create-rules flag
Screenshot 2024-09-06 194631

2.When we use --create-rules flag, a warning message flashes, but default rule still gets created as before.

Screenshot 2024-09-06 195339 image
  1. Backward compatibility not getting affected:
image
  1. Firewall correctly getting created with --no-default-rules
Screenshot 2024-09-06 195446
  1. No firewall rules applied with --no-default-rules flag
Screenshot 2024-09-06 195526
  1. Error out when both flags are used:
image
  1. Updated Documentation
Screenshot 2024-09-06 200008

Praveen005 avatar Sep 06 '24 15:09 Praveen005

Hi @uzaxirr,

This PR is ready for review. Whenever you have a moment, could you please take a look at it?

Thank you!

Praveen005 avatar Sep 10 '24 09:09 Praveen005

@fulviodenza are you free to give it a look? Many thanks for all your availability

alessandroargentieri avatar May 06 '25 14:05 alessandroargentieri