cli icon indicating copy to clipboard operation
cli copied to clipboard

fix: reconsider behavior when providing a value lower than 500 for bu…

Open harsh082ip opened this issue 1 year ago • 4 comments

As mentioned in issue #394, the following changes have been made:

The command will now fail immediately for values less than 500 GB with an appropriate error message.

Introduced a --yes flag to automatically adjust the bucket size to the nearest multiple of 500 without prompting the user. For example: Warning: The size to create an object store must be a multiple of 500. Would you like to create an object store of 1000 GB instead? (y/n)? Using the --yes flag, users can bypass this prompt.

Improved the help message to make the minimum and default size requirements explicit: -s, --size int Size of the Object store in GB (minimum: 500) (default 500)

Screenshot: image

Please review and let me know if any changes are needed. @haardikdharma10 @uzaxirr @RealHarshThakur @alejandrojnm

harsh082ip avatar Jul 09 '24 22:07 harsh082ip

@fulviodenza are you free to give it a look?

alessandroargentieri avatar May 06 '25 14:05 alessandroargentieri

Hi @harsh082ip, thanks for your contribution!

While the original issue has already been marked as closed and some parts of it were resolved, I think we should discuss whether we want to let the --yes flag automatically select an higher size in this context. This could cause some confusion among customers and some churn when they receive an higher bill than they expected.

@alessandroargentieri @fulviodenza @uzaxirr thoughts?

giornetta avatar May 06 '25 14:05 giornetta

Hii @giornetta ,

Thanks for the context! I agree, auto-selecting a higher size with --yes might lead to unexpected charges. Happy to align on the best approach.

harsh082ip avatar May 06 '25 14:05 harsh082ip

Hi @fulviodenza, apologies for the delay — I've pushed the required changes. Let me know if anything else is needed.

harsh082ip avatar Jun 28 '25 05:06 harsh082ip