cli icon indicating copy to clipboard operation
cli copied to clipboard

Lack of error messages with some commands that should error out

Open fernando-villalba opened this issue 1 year ago • 2 comments

Issue

Many commands that should error out, don't.

For example

civo kubernetes ls -o lefafa -f lefufu

There is no --output type lefafa or --field named lefufu

And yet the commands just goes ahead and works as if everything was fine:

% civo kubernetes ls -o lefafa -f lefufu                                                                                        
+--------------------------------------+----------+--------------+-------+-------+-------------------------------------+
| ID                                   | Name     | Cluster-Type | Nodes | Pools | Conditions                          |
+--------------------------------------+----------+--------------+-------+-------+-------------------------------------+
| e7747b8e-3fa7-4c2e-b6b8-e2473597a605 | test-app | k3s          |     1 |     1 | Control Plane Accessible: False     |
|                                      |          |              |       |       | All Workers Up: False               |
|                                      |          |              |       |       | Cluster On Desired Version: Unknown |
|                                      |          |              |       |       |                                     |
+--------------------------------------+----------+--------------+-------+-------+-------------------------------------+

Another example:

% civo kubernetes create --size g4s.kube.xsmall --nodes 1 test2 test3 test4 

The cluster test2 (524a3998-1639-4fed-995c-fcd6dc1aa2d0) has been created
fernandovillalba@Fernandos-MacBook-Pro-2 tempo-tutorial % civo k3s ls                                                               
+--------------------------------------+-------+--------------+-------+-------+-------------------------------------+
| ID                                   | Name  | Cluster-Type | Nodes | Pools | Conditions                          |
+--------------------------------------+-------+--------------+-------+-------+-------------------------------------+
| 524a3998-1639-4fed-995c-fcd6dc1aa2d0 | test2 | k3s          |     1 |     1 | Control Plane Accessible: False     |
|                                      |       |              |       |       | All Workers Up: False               |
|                                      |       |              |       |       | Cluster On Desired Version: Unknown |
|                                      |       |              |       |       |                                     |
+--------------------------------------+-------+--------------+-------+-------+-------------------------------------+

Despite giving multiple cluster names, it just goes ahead and creates the first one, ignoring all others. This should either error out, or allow the creation of multiple clusters with multitple parameters.

Acceptance Criteria

  1. Error out whenever the wrong --output flag value is passed. Same for --field
  2. Amend the behaviour of multiple name parameters for kubernetes to either create multiple clusters or failing saying that it expected just one parameter.

fernando-villalba avatar Apr 26 '24 11:04 fernando-villalba

Can these be treated as separate issues?

olamilekan000 avatar Oct 10 '24 23:10 olamilekan000

@olamilekan000 Definitely! Feel free to pick up any of the above and raise a PR!

giornetta avatar May 06 '25 14:05 giornetta