react-waypoint icon indicating copy to clipboard operation
react-waypoint copied to clipboard

Unable to resolve dependency tree

Open danyi1212 opened this issue 4 years ago • 6 comments

Hey, I'm getting those errors when trying to install this module:

npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR!   react@"^17.0.1" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^15.3.0 || ^16.0.0" from [email protected]
npm ERR! node_modules/react-waypoint
npm ERR!   react-waypoint@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Is that because the react version? React 17 is not supported?

danyi1212 avatar Feb 16 '21 19:02 danyi1212

@danyi1212 Yeah, I think that's why. I did "npm i react-waypoint --force" to workaround this.

Sergecodes avatar Feb 21 '21 17:02 Sergecodes

I think it should be closed once react@17 is already as peer dependency over here https://github.com/civiccc/react-waypoint/blob/master/package.json#L39

renatobenks avatar Feb 23 '21 21:02 renatobenks

cc @lencioni @trotzig

renatobenks avatar Feb 23 '21 21:02 renatobenks

The latest published version v9.0.3 (from July 2020) does not contain this fix, which was added in Nov. 2020.

DesignByOnyx avatar Feb 25 '21 23:02 DesignByOnyx

Can someone release the code on master please?

@lencioni @trotzig @sds @eslingerbryan @johndotpub @jamesplease

slorber avatar Mar 16 '21 18:03 slorber

@lencioni shouldn't you close this one once it was solved since https://github.com/civiccc/react-waypoint/releases/tag/v10.0.0?

renatobenks avatar Aug 01 '21 16:08 renatobenks