purescript-httpure

purescript-httpure copied to clipboard

Create separate types for request and response headers

2

Closes #157. This pull request separates the `Headers` type into `RequestHeaders` and `ResponseHeaders` respectively, as discussed in https://github.com/cprussin/purescript-httpure/issues/157#issuecomment-651394137. The only breakage this introduces is with module imports. The `headers` and...

sjpgarcia

Discussion / feature-request: allow using a monad other than Aff with HTTPure.serve

5

I have just converted my app to use `monad-logger` and as a result I have replaced `Aff a` with `LoggerT Aff a` in many places in the codebase. `HTTPure.serve` is...

Dretch

Extend apis of low level serve functions to accept parser configuration

1

Per @paluh in #129: > Maybe we can extend low level API of `serve'` and `serveSecure'` so they accept additional configuration which can be used in our final `fromHTTPRequest` for...

cprussin

Continuation of discussion started [here](https://github.com/cprussin/purescript-httpure/pull/104#issuecomment-419585619). @paluh had raised some concerns that perhaps using a typeclass for `Body` is not the best decision, and we would be better served by making...

cprussin

Allow multiple SetCookie headers in response

22

The current implementation does not allow setting more than one cookie. Only one SetCookie header is allowed in response. Is this behaviour intended? Or am I missing something?

Kamirus

Make `Status` a bit more safe and signature friendly

1

I love simplicity and efficiency of the current `Status` representation. I wonder if we want to add a tiny layer of typing around it (so we have readable signatures): ```purescript...

paluh

How to handle `Expect: 100-continue`?

2

I'm trying to handle [`Expect`][] headers and I'm unsure if it's possible with `httpure`: > An origin server MUST, upon receiving an HTTP/1.1 (or later) request-line and a complete header...

joneshf

Support duplicate keys in `Query`

8

There are multiple issuess with current `Query` representation: * `fullPath` - doesn't return original value of uri. We are not able to call it "equivalent" from my perspecitve, * We...

paluh

Better error handling

6

We need better sad-path handling. Things like: - [ ] Request closed by client while in flight - [ ] Exception while running router - [ ] Others?

cprussin

We had an expensive bug caused by incorrect concatenation code. The concatenation code was untested for multiple chunks, or it would have been caught earlier. We should add a unit...

cprussin