concourse icon indicating copy to clipboard operation
concourse copied to clipboard
verified publisher icon cinchapi

feature/CON-265

Open robertcli opened this issue 6 years ago • 3 comments

Review for Jeff

robertcli avatar Aug 07 '19 14:08 robertcli

Latest commit contains SpotlessApply.

robertcli avatar Aug 09 '19 19:08 robertcli

I reversed the order of the history and undo(changes, key, record) is now undoing results accurately. Also: added <= to while loop.

NORMAL: 1565204100041001 ADD hi AS 5 (INTEGER) IN 1 AT 1565204100041001 NORMAL: 1565204154077001 REMOVE hi AS 5 (INTEGER) IN 1 AT 1565204154077001 NORMAL: 1565204154078000 ADD hi AS bye (STRING) IN 1 AT 1565204154078000 NORMAL: 1565282665359000 ADD hi AS 5 (INTEGER) IN 1 AT 1565282665359000 NORMAL: 1565282665363000 REMOVE hi AS bye (STRING) IN 1 AT 1565282665363000

REVERSE: 1565282665363000 REMOVE hi AS bye (STRING) IN 1 AT 1565282665363000 REVERSE: 1565282665359000 ADD hi AS 5 (INTEGER) IN 1 AT 1565282665359000 REVERSE: 1565204154078000 ADD hi AS bye (STRING) IN 1 AT 1565204154078000 REVERSE: 1565204154077001 REMOVE hi AS 5 (INTEGER) IN 1 AT 1565204154077001 REVERSE: 1565204100041001 ADD hi AS 5 (INTEGER) IN 1 AT 1565204100041001

robertcli avatar Aug 09 '19 21:08 robertcli

@robertcli you should write some unit tests

jtnelson avatar Aug 10 '19 13:08 jtnelson