Cijo Thomas

Results 1315 comments of Cijo Thomas

Can anyone share a repro code which results in duplicate peer.service tags?

This feels like a specification issue. Every language implementations follow the OTel specification https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk_exporters/prometheus.md Also - Exemplars are not yet implemented in OpenTelemetry .NET

Yes. But Exemplars feature itself is not implemented.

Metrics and Traces are independently enabled/disabled in OpenTelemetry. One good option would be to derive metrics from traces in the collector. (Though this has accuracy/latency implications.)

There was an attempt to use `ILogger` for sending internal logs. Its not merged, and was proposed to be part of OTel.Extensions.Hosting package. When that is resurrected, it might be...

Once https://github.com/open-telemetry/opentelemetry-dotnet/pull/2864 is merged, it'll allow a good amount of customization. (It wont be part of the coming 1.2 stable). There is a fairly involved refactoring done to fix some...

This is something which requires some discussion/design. Current instrumentations populate only the required fields, and any other fields which are readily available (without much perf cost). We need to find...

https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OpenTelemetry.Exporter.OpenTelemetryProtocol.csproj#L10-L16 Looks like we already use the Grpc.Net.Client for netstandard2.1_or_higher. The package did not originally support netstandard2.0.. @alanwest explored this, in the context of Grpc instrumentation as well.

@vishweshbankwar can you check this?

Sure. I wanted to wait till https://github.com/open-telemetry/opentelemetry-proto/pull/279 is merged. But we don't have to wait really for that.