cibernox
Possibility of splitting onOpen & onClose to before & after actions?
First I want to say thank you for this most excellent ember addon, which is so foundational to many other addons!!
Second I wanted to ask if you'd be open to deprecating onOpen and onClose in favor of beforeOpen and beforeClose as well as adding afterOpen and afterClose hooks.
Or if it's possible to achieve after hooks some other way I'd be very interested to learn!
In case it wasn't clear -- if you're open to considering a PR that would do this, I'm happy to take a stab at implementing it and opening a PR
the afterOpen and afterClose hooks will be very helpful! Am trying to paginate my search but require the height of the component which I will not able to get onOpen(as per my understanding).
I agree with @sdhull's suggestion. The split up actions are gonna be super helpful!
Thanks for the great addon! :)
I think it's a good idea, but I'm short of time lately.
The approach would be to add a onBeforeOpen/onAfterOpen and onBeforeClose/onAfterOpen, and, for backwards-compatibility, map the current onOpen/onClose to onBeforeOpen/onBeforeClose with a deprecation, to eventually be removed in 2.0.
If anyone wants to take a stab let me know, I might be able to assist
I will likely take a stab at it this week.
On Tue, Dec 11, 2018 at 11:19 AM Miguel Camba [email protected] wrote:
I think it's a good idea, but I'm short of time lately.
The approach would be to add a onBeforeOpen/onAfterOpen and onBeforeClose/ onAfterOpen, and, for backwards-compatibility, map the current onOpen/ onClose to onBeforeOpen/onBeforeClose with a deprecation, to eventually be removed in 2.0.
If anyone wants to take a stab let me know, I might be able to assist
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cibernox/ember-basic-dropdown/issues/420#issuecomment-446327150, or mute the thread https://github.com/notifications/unsubscribe-auth/AADDd-yTQ9WvtkSP1O-ZGFttQwnVmb1wks5u4AVKgaJpZM4VuzIL .