node-oauth icon indicating copy to clipboard operation
node-oauth copied to clipboard
verified publisher icon ciaranj

Add underlying http request agent configuration support to oauth2

Open kulkame opened this issue 8 years ago • 6 comments

We experienced an issue where we needed to adjust http request agent configurations but could not find anyway of configuring passport oauth2 to propagate those configurations to the underlying library. This PR should resolve that issue in a generic way that is hopefully applicable to future use cases as well.
Similar issue reported https://github.com/ciaranj/node-oauth/issues/329

kulkame avatar May 22 '17 15:05 kulkame

This is an great solution and would help me out with an issue I faced with self signed certificates.

Please merge!

msweaver avatar May 22 '17 15:05 msweaver

This helped me out too! Please merge!

SwapnilParanjape avatar May 22 '17 16:05 SwapnilParanjape

When will this PR be merged? I am facing similar issue.

hsalunkhe avatar May 23 '17 08:05 hsalunkhe

I don't quite understand, why doesn't 6baf574f8762232ee69a8d4e487db57e9215d614 satisfy your requirements?

ciaranj avatar May 23 '17 08:05 ciaranj

@kulkame or @ciaranj can either of you please elaborate why one solution is better than the other? Hopefully in a way that everybody else can then use it?

joh-klein avatar Jun 07 '17 15:06 joh-klein

@kulkame you may want to try submitting a patch against my fork: https://github.com/omouse/node-oauth-libre I merged a similar patch many months ago (related to Authorization header for oauth2)

ghost avatar Jun 18 '17 23:06 ghost