robots icon indicating copy to clipboard operation
robots copied to clipboard

Feature/fix mini pupper config

Open CullenSUN opened this issue 3 years ago • 3 comments

CullenSUN avatar Sep 22 '22 16:09 CullenSUN

hey @CullenSUN . Could you remove the AMENT_IGNORE and uncomment all the description repos before I approve the PR. Appreciate the PR but please keep in mind that this is a common config repo and not just for mini pupper, so please be mindful of changes that disrupt other robot's configuration.

grassjelly avatar Oct 04 '22 11:10 grassjelly

Let me make excuses, this was a consideration so that people who wanted to use the ROS 2 version champ would not be troubled by errors while colcon build. However, the intention of not wanting to merge unnecessary changes besides updating the mini pupper's config makes sense and should be respected. @CullenSUN Could you revert my commit (321f4ad) and update the pull request?

Tiryoh avatar Oct 04 '22 13:10 Tiryoh

hi @grassjelly got it. Will keep that in mind. Hi @grassjelly , @Tiryoh please review again. thx

CullenSUN avatar Oct 04 '22 13:10 CullenSUN