David Holdeman

Results 107 comments of David Holdeman

Also, small fun fact: The short board name for config/boards/nucleo_h743 in gen_config.sh is "nucleo_h743", but in config/boards/nucleo_h743/meta-info.env it's "stm32h743_nucleo", as I copied it [from build_firmware.yaml.](https://github.com/chuckwagoncomputing/rusefi/commit/4ae60f4d36ac8042ec909effa2e664ab07f2c223#diff-fd6a34015e12e374d49724f684d3b6cc6088f0a4dd911afcde45c2c93d24ff04L395)

I refuse to try to parse yaml with regex. Using a tool like https://github.com/mikefarah/yq as I do with https://github.com/chuckwagoncomputing/interactive-pinout is the only acceptable option. However, if we only have one...

For gen_config.sh, do we want to generate config for all boards that do not have SKIP_RATE=100, or are there exceptions to that?

Re: `cmp ${TEMP_FILE} ${SIGNATURE_FILE_NAME} || mv -f ${TEMP_FILE} ${SIGNATURE_FILE_NAME}` cmp compares files to see if they are different. If `SIGNATURE_FILE_NAME` is missing it will print an error but, the `mv`...

I'm thinking the best place to call a post-build script would be right before zipping the bundles. https://github.com/rusefi/rusefi/blob/8f60601a3d103c047c4ad1691ea97c9aff051728/firmware/bundle.mk#L164-L168

I could certainly add a pre-build script. What would the pre-build script do? If the pre-build script is just modifying files, it's pretty simple, but it gets much more complex...

I still don't know what the goal of a pre-build script would be, but as of now I don't think the makefile is the right place for it.

Fixed with: https://github.com/rusefi/rusefi/commit/20972847de3821ee38ceb441f0ae76714ad82a7d

`make` makes firmware `make bundle` makes everything (but not yet)