chrono icon indicating copy to clipboard operation
chrono copied to clipboard

move shell commands to yml

Open esheppa opened this issue 3 years ago • 6 comments

esheppa avatar Sep 01 '22 12:09 esheppa

Would you mind splitting the first commit into pieces, maybe one part per job or something? I think the move of the date command tests should be in a separate commit as well. Otherwise this gets too hard to review.

The other commits look good to me, thanks for working on this!

djc avatar Sep 02 '22 10:09 djc

There are still a few things I need to do here (some of which may be better in a separate PR)

  • Consider whether we need ubuntu-20.04 - I've currently removed this but it was probably there for a reason.
  • Consider whether we need to run the no_std/alternative-targets/cross-targets elsewhere than linux (previous was running also on macOS)
  • Re-implement the wasm simple test (using wasm-pack, or perhaps trunk).
  • Run on android (I've added a build for this but could be nice to run the tests as well)
  • Potentially consolidate the cross-targets and no-std blocks,
  • Potentially move android and iOS to the cross-targets block
  • Potentially add some more common targets
  • Potentially run the no_std tests using QEMU to emulate the target

esheppa avatar Sep 02 '22 12:09 esheppa

This is looking great! So the one thing I would probably do different is to remove stuff from the shell scripts in the same commit as it is added/moved in the CI config, so it's easier to review how coverage changes. Do you think that would be hard to do?

djc avatar Sep 05 '22 09:09 djc

Yep that sounds like a good move, and makes it one less commit as well.

esheppa avatar Sep 05 '22 13:09 esheppa

potentially this should target 0.4.x instead of main, and then it can later be merged to main - this would be nice as we can avoid maintaining two CI setups

esheppa avatar Sep 08 '22 11:09 esheppa

Yes, merging this into 0.4.x first makes sense to me.

djc avatar Sep 08 '22 11:09 djc

This has been merged via #814 instead

esheppa avatar Sep 26 '22 12:09 esheppa