web-developer icon indicating copy to clipboard operation
web-developer copied to clipboard

Fix dns lookup passing full url to website instead of domain

Open s0m31-hub opened this issue 2 years ago • 4 comments

Now, when View DNS records feature is used only domain will be passed to lookup website

s0m31-hub avatar Aug 29 '23 09:08 s0m31-hub

p.s. I am not really a frontend developer.

In ideal world, this fix should be rewritten in a separate function. But it will work fine in most cases for now

s0m31-hub avatar Aug 29 '23 09:08 s0m31-hub

Thanks for the pull request! Ideally I want to fix this as part of adding standard support for domains vs. URLs which is on the to-do list:

https://chrispederick.com/work/web-developer/to-do/#item-4E5F8488-FD05-417A-B902-AE6B1667322D

That will be more robust than trying to match based on the URL of the tool, but I'll leave this PR open until I get the chance to work on this.

chrispederick avatar Sep 11 '23 21:09 chrispederick

🇬🇧 For years I have been using your software. I translated this one in my mother tongue French but impossible then to share it with the community.

  • In Google Chrome no problem for French to be supported, it works 100%

  • In Firefox (the main browser at home) impossible to pass your software in French and yet it works without any concern in debugging mode.

I would so much like to offer you my work but I do not know how to transform into .xpi the basic folder in which I added the "FR_FR" folder and inside the "messages.json" file fully translated.

How can I offer you all this to thank you for inventing Web Developer which has been doing so many service for many for so many years.

🇲🇫 In french: Depuis des années j'utilise votre soft. J'ai traduit celui ci dans ma langue maternelle le francais mais impossible ensuite d'en faire profiter la communauté. -- Dans Google Chrome aucun problème pour que le français soit pris en charge, ça fonctionne à 100%

  • Dans Firefox (le navigateur principal chez moi) impossible de passer votre logiciel en Français et pourtant il fonctionne sans aucun souci en mode débogage.

J'aimerais tant vous offrir mon travail mais je ne sais pas comment faire pour transformer en .xpi le dossier de base dans lequel j'ai ajouté le dossier "fr_FR" et dedans le fichier "messages.json" entièrement traduit.

Comment puis je vous offrir tout ceci pour vous remercier d'avoir inventé Web Developer qui rend tant de service à beaucoup depuis tant d'années.

2

traduit

original

lapervenche avatar Feb 12 '24 15:02 lapervenche

I am working on some major updates to the extension and plan on looking into localization options after that is done. Once I have more details I'll post an update and ask for help.

chrispederick avatar Feb 23 '24 19:02 chrispederick