chrismccord
Initial Pubnub build
That's what I told you, I didn't test the Javascript side of the application because I didn't have your test application, so most certainly, the PubNub adapter isn't complete. If you can bundle it in the test suite, I'll update my gem and send you a new pull request when stuff is working. The specs do work though, so it should be some minor issues.
I'm close to a working pubnub javascript adapter, using your implementation as the base. I just wanted to be sure I wasn't missing something. Sorry the delay on this. I hope to have it merged in soon.
No need to be sorry mate, I contributed to your project cause it's awesome if we can have more adapters!
@chrismccord Any updates on this? Would love to see it added. If you need help with anything in particular, let me know. :)
@seangaffney using @gmaliar's branch as a template, it should be straight forward to get in place. Unfortunately, I don't have the time to get this in place right now, but would love to accept it as a pull request :)
Hey Sean, if you'd like to pair program this one up I'd be more than happy to give a hand.
@chrismccord, The test application you set up in the video, can you open a new repository for it? I'll merge it into the test for this gem and PR it, that way we can work on the javascript side as well.
@gmaliar You should be able to fork https://github.com/chrismccord/sync_example, and make a branch to testbed this feature on.
Hey Chris, I’ve forked and fixed the adapter, there’s some issue with some Javascript that is not re-rendering correctly. When I try to mark a todo item as done, Sync re-renders the header correctly and also publishes the message and updates another open browser window (using the Pubnub adapter), but the javascript that suppose to strikethrough the item does not strikethrough on either browsers (the publisher and the subscribed one)
Any thoughts?
-- Guy Maliar Sent with Airmail
On August 3, 2013 at 8:01:15 PM, Chris McCord ([email protected]) wrote:
@gmaliar You should be able to fork https://github.com/chrismccord/sync_example, and make a branch to testbed this feature on.
— Reply to this email directly or view it on GitHub.
@gmaliar are you still interested in working to get this merged? I was just added as a maintainer on this repo, and I'd be happy to review/provide feedback if that would help.
