solga icon indicating copy to clipboard operation
solga copied to clipboard

Build failure with GHC 8.2

Open snoyberg opened this issue 8 years ago • 4 comments

[1 of 1] Compiling Solga            ( src/Solga.hs, dist/build/Solga.o )

src/Solga.hs:286:11: error:
    • The default type signature for brief: a -> a
      does not match its corresponding non-default type signature
    • When checking the class method:
        brief :: forall a. Abbreviated a => Brief a -> a
      In the class declaration for ‘Abbreviated’
    |
286 |   default brief :: a -> a
    |           ^^^^^

snoyberg avatar Jul 31 '17 08:07 snoyberg

I had a crack at this here: https://github.com/FintanH/solga/tree/build_error

For the build error, I thought adding an equational constraint would fix it i.e. https://github.com/FintanH/solga/blob/build_error/solga/src/Solga.hs#L286

I'm not too familiar with type families so I'm not entirely sure if this is a good solution.

FintanH avatar Aug 03 '17 17:08 FintanH

@FintanH Your fix seems like it works without issue for me.

sordina avatar Mar 28 '19 06:03 sordina

@sordina Have a fix here: https://github.com/chpatrick/solga/pull/14

FintanH avatar Mar 28 '19 11:03 FintanH

@FintanH awesome!

sordina avatar Mar 29 '19 08:03 sordina