Chowder comments

Results 14 comments of


                                            Chowder

plain invocation of python subprocess doesn't inherit sys.path for bootstrap_impl=script

#2409 also seems to have broken `py_binary` and `py_test` targets in multi-python setups. Trivial reproduction: 1. open `examples/multi_python_versions` 2. set `--@rules_python//python/config_settings:bootstrap_impl=script` 3. try to run any of the targets under...

plain invocation of python subprocess doesn't inherit sys.path for bootstrap_impl=script

Ok - so I don't quite understand the original logic - but I think the correct logic for this: https://github.com/bazelbuild/rules_python/blob/4ee7e256de85faff38db5f21defd660a2cd6aa85/python/private/py_executable_bazel.bzl#L370-L374 is supposed to be: **EDIT: ignore the below - i'm...

plain invocation of python subprocess doesn't inherit sys.path for bootstrap_impl=script

They're not equivalent, no - can you try these changes out please? https://github.com/bazelbuild/rules_python/pull/2439/files

plain invocation of python subprocess doesn't inherit sys.path for bootstrap_impl=script

OHH okay, I think see how this is supposed to work now. @ewianda I've updated the PR The only case it doesn't cover is an external rule using a Python...