nanomorph icon indicating copy to clipboard operation
nanomorph copied to clipboard

benchmark

Open yoshuawuyts opened this issue 8 years ago • 4 comments

It'd be neat to have a benchmark to test our diffing needs — perf is a feature, and we should be able to catch regressions.

Given this would need to run in the browser, we'd probably need some tooling around this. I was thinking it'd be cool to run a headless Chrome instance through puppeteer, and use the nanobench module to perform the benches. Would be neat if we could run it as a standalone CLI thing, with similar output to TAP.

But by all means — feel free to pick up this issue, and run with it. Probably worth picking up similar benches as in https://github.com/choojs/choo/issues/492.

Hope this makes sense. Thanks!

yoshuawuyts avatar Nov 01 '17 16:11 yoshuawuyts

FWIW we have some benchmarks setup for emotion that use puppeteer and run on every ci build. Might be some useful stuff to steal. https://github.com/emotion-js/emotion/tree/master/packages/benchmarks

tkh44 avatar Nov 01 '17 17:11 tkh44

This looks interesting. I would be happy to take it on.

him2him2 avatar Nov 01 '17 21:11 him2him2

It'd be cool as I believe there was some regression of choo 5 vs 6, and it chould've been caught

We can do a CI docker build to run it automatically on npm release bumps, this would be best solution

graforlock avatar Nov 01 '17 23:11 graforlock

@him2him2 amazing! :D

yoshuawuyts avatar Nov 04 '17 16:11 yoshuawuyts