chisel icon indicating copy to clipboard operation
chisel copied to clipboard

Add recursive `Bundle` and generic `Data` equality (===)

Open jared-barocsi opened this issue 3 years ago • 0 comments

Contributor Checklist

  • [ ] Did you add Scaladoc to every public function/method?
  • [x] Did you add at least one test demonstrating the PR?
  • [x] Did you delete any extraneous printlns/debugging code?
  • [x] Did you specify the type of improvement?
  • [x] Did you add appropriate documentation in docs/src?
  • [x] Did you state the API impact?
  • [x] Did you specify the code generation impact?
  • [x] Did you request a desired merge strategy?
  • [x] Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • new feature/API

API Impact

  • Adds recursive === operator to Data types

Backend Code Generation Impact

No impact

Desired Merge Strategy

Squash and merge

Release Notes

Implement recursive Bundle and Data equality

  • This allows Bundle and Data objects to be compared with === directly, without any additional steps like casting to UInt

Reviewer Checklist (only modified by reviewer)

  • [ ] Did you add the appropriate labels?
  • [ ] Did you mark the proper milestone (Bug fix: 3.4.x, [small] API extension: 3.5.x, API modification or big change: 3.6.0)?
  • [ ] Did you review?
  • [ ] Did you check whether all relevant Contributor checkboxes have been checked?
  • [ ] Did you do one of the following when ready to merge:
    • [ ] Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • [ ] Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

jared-barocsi avatar Aug 10 '22 22:08 jared-barocsi