chisel icon indicating copy to clipboard operation
chisel copied to clipboard

Speed up ci

Open jackkoenig opened this issue 4 years ago • 2 comments

We need to just do https://github.com/chipsalliance/chisel3/pull/2043, but I want to see if some tests take a lot longer than others

Contributor Checklist

  • [ ] Did you add Scaladoc to every public function/method?
  • [ ] Did you add at least one test demonstrating the PR?
  • [ ] Did you delete any extraneous printlns/debugging code?
  • [ ] Did you specify the type of improvement?
  • [ ] Did you add appropriate documentation in docs/src?
  • [ ] Did you state the API impact?
  • [ ] Did you specify the code generation impact?
  • [ ] Did you request a desired merge strategy?
  • [ ] Did you add text to be included in the Release Notes for this change?

Type of Improvement

API Impact

Backend Code Generation Impact

Desired Merge Strategy

Release Notes

Reviewer Checklist (only modified by reviewer)

  • [ ] Did you add the appropriate labels?
  • [ ] Did you mark the proper milestone (Bug fix: 3.3.x, [small] API extension: 3.4.x, API modification or big change: 3.5.0)?
  • [ ] Did you review?
  • [ ] Did you check whether all relevant Contributor checkboxes have been checked?
  • [ ] Did you mark as Please Merge?

jackkoenig avatar Jan 12 '22 18:01 jackkoenig

Sorry I forgot that PR... Need I rework on that?

sequencer avatar Jan 27 '22 22:01 sequencer

It might also make sense to move some more of the chisel execution tests to our integration-tests project which can make use of chiseltest and thus potentially more easily target different solvers. At a minimum it would load balance things a bit since the integration-test run in parallel to the regular tests.

ekiwi avatar Jun 28 '22 02:06 ekiwi

I am generally nervous as to how this is going to work when pushing towards MFC. However, we can always switch back with no-cost.

Agreed, but nice to reap some benefits in the meantime!

I would highly advised that no Treadle-specific features somehow creep into CI. As far as I know, no such features actually exist.

Yeah good to keep in mind. For the time being, all tests that run with Treadle are run with Verilator during post-merge CI (aka on "push"). We should keep it that way.

jackkoenig avatar Sep 27 '22 19:09 jackkoenig